> On Nov. 21, 2016, 2:13 a.m., Qian Zhang wrote: > > src/cli/execute.cpp, line 807 > > <https://reviews.apache.org/r/53624/diff/3/?file=1561158#file1561158line807> > > > > I see the default value of `flags.content_type` is "json", so should we > > change this line to `mesos::ContentType contentType = > > mesos::ContentType::JSON;` for consistence?
Thanks, I posted https://reviews.apache.org/r/53957/ - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/#review156432 ----------------------------------------------------------- On Nov. 11, 2016, 12:49 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53624/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 12:49 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6562 > https://issues.apache.org/jira/browse/MESOS-6562 > > > Repository: mesos > > > Description > ------- > > Using the JSON content type in mesos-execute makes packet tracing > protocol interactions easier. Add a --content_type option that > switched between protobuf (the default) and JSON content types. > > > Diffs > ----- > > src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 > > Diff: https://reviews.apache.org/r/53624/diff/ > > > Testing > ------- > > make check. Manually verified with tcpdump. > > > Thanks, > > James Peach > >
