----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52652/#review156256 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Oct. 7, 2016, 3:19 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52652/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 3:19 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The multiplication and division operators for `Bytes` take a `double` > argument. Changing this to an unsigned integer removes the implicit > `double` to `uint64_t` casting. These operators are currently only > used in tests. > > > Diffs > ----- > > 3rdparty/stout/include/stout/bytes.hpp > 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 > 3rdparty/stout/tests/bytes_tests.cpp > 9d32ea141cdb0ec3f03a8dad6b567afdd1e026c4 > > Diff: https://reviews.apache.org/r/52652/diff/ > > > Testing > ------- > > See next review. > > Supercedes this review: https://reviews.apache.org/r/52192/ > > > Thanks, > > Joseph Wu > >
