----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review156280 -----------------------------------------------------------
Ship it! We might want to update the description of the commit to mention where we're going with this change (i.e. allow health checks to run forever and let the scheduler make the decision about how to deal with unhealthy tasks). src/health-check/health_checker.hpp (line 71) <https://reviews.apache.org/r/52865/#comment226482> How about '`initialize`'? Later, when you introduce pause/resume functionality, we could call them start/stop and avoid the need for an initialize function, right? - Benjamin Mahler On Nov. 14, 2016, 10:27 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52865/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 10:27 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > Prior to this patch, HealthChecker would stop performing health > checks after it marks the task for kill. Since tasks' lifecycle > is managed by scheduler-executor, HealthChecker should never stop > health checking on its own. > > > Diffs > ----- > > src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 > src/health-check/health_checker.hpp > a1dc72493ff31b87068d5691f4d5b794392caf76 > src/health-check/health_checker.cpp > e2b32e2d57515202f547d12ba492ad8eb633641b > src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf > src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 > > Diff: https://reviews.apache.org/r/52865/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
