----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53804/#review156476 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp (lines 330 - 332) <https://reviews.apache.org/r/53804/#comment226658> It looks like windows happens to define the same values as Linux for shutdown, but with different macro names: ``` // Windows: SD_RECEIVE = 0 SD_SEND = 1 SD_BOTH = 2 // Linux: SHUT_RD = 0 SHUT_WR = 1 SHUT_RDWR = 2 ``` But it looks like POSIX only specifies that the macro names have to map to distinct values, but doesn't seem to specify the values. After looking at how this works on windows I noticed this: https://github.com/apache/mesos/blob/b5c11a2e84e0d9102e73148c0651d2d53fd22e56/3rdparty/stout/include/stout/windows.hpp#L170-L173 Seems this should be updated to include `SHUT_WR` and `SHUT_RDWR` so that when users pass these values it compiles on windows. - Benjamin Mahler On Nov. 16, 2016, 1:24 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53804/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 1:24 a.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5658 > https://issues.apache.org/jira/browse/MESOS-5658 > > > Repository: mesos > > > Description > ------- > > This patch adds a parameter to the `Socket::shutdown` function > which allows callers to specify whether they would like the > read end, write end, or both ends of the socket to be shutdown. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > f798af7879546d71e8ef4a295c9cf489a70cb61f > > Diff: https://reviews.apache.org/r/53804/diff/ > > > Testing > ------- > > Testing details are found at the end of this review chain. > > > Thanks, > > Greg Mann > >
