> On Nov. 21, 2016, 6:03 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/socket.hpp, lines 332-337 > > <https://reviews.apache.org/r/53804/diff/1/?file=1564885#file1564885line332> > > > > It seems a better default would be a full shutdown rather than a > > partial shutdown, want to add a TODO for that?
How about removing the default altogether to more closely match BSD sockets? I added the TODO and linked to a related ticket. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53804/#review156474 ----------------------------------------------------------- On Nov. 22, 2016, 6:22 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53804/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 6:22 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5658 and MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5658 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > Added a parameter to 'Socket::shutdown' to specify 'how'. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > f798af7879546d71e8ef4a295c9cf489a70cb61f > > Diff: https://reviews.apache.org/r/53804/diff/ > > > Testing > ------- > > Testing details are found at the end of this review chain. > > > Thanks, > > Greg Mann > >
