----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53546/#review156681 -----------------------------------------------------------
Hi Haosdent! I think the subsystem name for PIDs is `pids` instead of `pid` (look at the example below). We should rename it also for the purpose of avoiding confusion with the PID namespace isolator. ``` $ cat /proc/cgroups #subsys_name hierarchy num_cgroups enabled cpuset 3 21 1 cpu 2 150 1 cpuacct 2 150 1 blkio 5 150 1 memory 10 208 1 devices 7 150 1 freezer 9 21 1 net_cls 6 21 1 perf_event 8 21 1 net_prio 6 21 1 pids 4 152 1 ``` - Jason Lai On Nov. 15, 2016, 5:18 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53546/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 5:18 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, Qian Zhang, and > Jiang Yan Xu. > > > Bugs: MESOS-6558 > https://issues.apache.org/jira/browse/MESOS-6558 > > > Repository: mesos > > > Description > ------- > > Added stub classes for rest cgroups subsystems. > > > Diffs > ----- > > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > src/slave/containerizer/mesos/containerizer.cpp > 67cc595278f124cdf518d2f4fcfb257439f067e2 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2f6723c64261fb3295626d6479fe844fb23b0650 > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > 8c73efdfcfd3cf48a12cf81fcd075166dc51d7e3 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > bf7dc9e7efb183879bfb525cc7ecfac4cc53dbef > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/53546/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
