> On Nov. 23, 2016, 1:20 a.m., Jason Lai wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp, line > > 37 > > <https://reviews.apache.org/r/53546/diff/1/?file=1555581#file1555581line37> > > > > `CpuSetSubsystem`?
Should be CpusetSubsystem. For example, we use NetClsSubsystem for the net_cls subsystem and we didn't use CpuAcctSubsystem for cpuacct. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53546/#review156678 ----------------------------------------------------------- On Nov. 23, 2016, 4:20 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53546/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 4:20 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, Qian Zhang, and > Jiang Yan Xu. > > > Bugs: MESOS-6558 > https://issues.apache.org/jira/browse/MESOS-6558 > > > Repository: mesos > > > Description > ------- > > Added stub classes for rest cgroups subsystems. > > > Diffs > ----- > > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 > src/slave/containerizer/mesos/containerizer.cpp > e47a120bfbb607cc0cdbdaed934ae15f15666ae3 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 3955cc461f15a0465d4ea500726798e3a13dc0ef > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > 8c73efdfcfd3cf48a12cf81fcd075166dc51d7e3 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > bf7dc9e7efb183879bfb525cc7ecfac4cc53dbef > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/pids.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/pids.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/53546/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
