----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156776 -----------------------------------------------------------
Fix it, then Ship it! LGTM, just a few minor style nits to take care of. src/common/recordio.hpp (line 99) <https://reviews.apache.org/r/54039/#comment227054> Space after `<` src/common/recordio.hpp (lines 101 - 103) <https://reviews.apache.org/r/54039/#comment227059> You might want to reorder the arguments based on the comments above i.e., `Reader`, `func` (transformation), `writer`. src/common/recordio.hpp (lines 107 - 128) <https://reviews.apache.org/r/54039/#comment227058> Indent by 2 spaces inside the lambda too i.e., after `onAny(...)`. src/common/recordio.hpp (line 116) <https://reviews.apache.org/r/54039/#comment227057> Unrelated to this review, can you also make a similar change to the scheduler/executor library for consistency. - Anand Mazumdar On Nov. 23, 2016, 7:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54039/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 7:20 p.m.) > > > Review request for mesos, Anand Mazumdar and Benjamin Mahler. > > > Bugs: MESOS-6473 > https://issues.apache.org/jira/browse/MESOS-6473 > > > Repository: mesos > > > Description > ------- > > This helper lets us transform raw bytes read from a RecordIO > reader and write to a pipe. > > > Diffs > ----- > > src/common/recordio.hpp cbd9d3667ba43eabb22c1af20853b8ed8e093852 > src/tests/common/recordio_tests.cpp > 86a111724bd303bbb17b84d8b32b811476c66b57 > > Diff: https://reviews.apache.org/r/54039/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
