----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156976 -----------------------------------------------------------
src/common/recordio.hpp (lines 128 - 130) <https://reviews.apache.org/r/54039/#comment227351> hmm, it's a bit unfortunate that we would _only_ notice a disconnection between the client and the agent when we try to write to the client response pipe. Can we rely on the `writer.readerClosed()` callback instead? If it's too much work, let's leave a TODO to clean it up later. src/tests/common/recordio_tests.cpp (line 164) <https://reviews.apache.org/r/54039/#comment227352> Can you also add tests to simulate the other two failure scenarios? - connection between client and agent breaks - connection between agent and switchboard breaks - Anand Mazumdar On Nov. 26, 2016, 5:41 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54039/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2016, 5:41 p.m.) > > > Review request for mesos, Anand Mazumdar and Benjamin Mahler. > > > Bugs: MESOS-6473 > https://issues.apache.org/jira/browse/MESOS-6473 > > > Repository: mesos > > > Description > ------- > > This helper lets us transform raw bytes read from a RecordIO > reader and write to a pipe. > > > Diffs > ----- > > src/common/recordio.hpp cbd9d3667ba43eabb22c1af20853b8ed8e093852 > src/tests/common/recordio_tests.cpp > 86a111724bd303bbb17b84d8b32b811476c66b57 > > Diff: https://reviews.apache.org/r/54039/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
