----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review156861 -----------------------------------------------------------
I think that `HealthChecker::stop()` should just terminate the actor, no need to introduce a boolean. - Gastón Kleiman On Nov. 23, 2016, 12:51 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52868/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 12:51 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 837d1358e418d21536da488e4a23cbfa41db6060 > src/health-check/health_checker.cpp > af5500be249c74a4a5e64bf38dea607173e2f998 > > Diff: https://reviews.apache.org/r/52868/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
