----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53761/#review157108 -----------------------------------------------------------
Fix it, then Ship it! cmake/MesosConfigure.cmake (line 142) <https://reviews.apache.org/r/53761/#comment227526> Interesting, for my own education: is this the same in the AC build solution? I don't see a target like this in the AC system, but I also don't really know what to search for. - Alex Clemmer On Nov. 15, 2016, 3:11 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53761/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 3:11 a.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > We need this extra level of targets in order to model the > dependency chain for binaries and libraries. An example > is the mesos-containerizer binary, which depends on libmesos > (i.e. MESOS_TARGET) but does not get included in the dependency > chain if you only depend on MESOS_TARGET. > > > Diffs > ----- > > cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 > > Diff: https://reviews.apache.org/r/53761/diff/ > > > Testing > ------- > > See next review. > > > Thanks, > > Joseph Wu > >
