> On Nov. 28, 2016, 11:04 a.m., Alex Clemmer wrote: > > cmake/MesosConfigure.cmake, line 142 > > <https://reviews.apache.org/r/53761/diff/1/?file=1563897#file1563897line142> > > > > Interesting, for my own education: is this the same in the AC build > > solution? I don't see a target like this in the AC system, but I also don't > > really know what to search for.
The automake build has some special variables that automatically add certain things to the build. The various programs like `mesos-agent` and `mesos-fetcher` are added to a `sbin_PROGRAMS` or `pkglibexec_PROGRAMS` target. These targets are implicit dependencies of the "default" make target (which is an implicit dependency on the make check target). See: https://www.gnu.org/software/automake/manual/html_node/The-Two-Parts-of-Install.html In CMake, there are no such implicit targets, so we end up creating "custom" targets to account for dependency chains. The `mesos-and-binaries` target is my replacement for automake's implicit "default" target. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53761/#review157108 ----------------------------------------------------------- On Nov. 14, 2016, 7:11 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53761/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 7:11 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > We need this extra level of targets in order to model the > dependency chain for binaries and libraries. An example > is the mesos-containerizer binary, which depends on libmesos > (i.e. MESOS_TARGET) but does not get included in the dependency > chain if you only depend on MESOS_TARGET. > > > Diffs > ----- > > cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 > > Diff: https://reviews.apache.org/r/53761/diff/ > > > Testing > ------- > > See next review. > > > Thanks, > > Joseph Wu > >
