----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/#review157191 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/namespaces/uts.cpp (lines 67 - 68) <https://reviews.apache.org/r/53627/#comment227631> Do we need to update this part to follow what we do in `namespace/pid` isolator? ``` Future<Option<ContainerLaunchInfo>> NamespacesPidIsolatorProcess::prepare( const ContainerID& containerId, const ContainerConfig& containerConfig) { ContainerLaunchInfo launchInfo; if (containerId.has_parent()) { // If we are a nested container, then we want to enter our // parent's pid namespace before cloning a new one. launchInfo.set_enter_namespaces(CLONE_NEWPID); // However, if we are a nested container in the `DEBUG` class, // then we don't want to clone a new PID namespace at all, so we // short cirucuit here. if (containerConfig.has_container_class() && containerConfig.container_class() == ContainerClass::DEBUG) { return launchInfo; } } launchInfo.set_clone_namespaces(CLONE_NEWPID); ``` src/tests/containerizer/isolator_tests.cpp (lines 59 - 64) <https://reviews.apache.org/r/53627/#comment227632> Move this after ``` #include "slave/containerizer/mesos/launcher.hpp" #include "slave/containerizer/mesos/paths.hpp" ``` Since it works in other operate systems as well. src/tests/containerizer/isolator_tests.cpp (lines 384 - 396) <https://reviews.apache.org/r/53627/#comment227633> I think we could simpify these line to ``` Owned<MasterDetector> detector = master.get()->createDetector(); Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), agentFlags); ASSERT_SOME(slave); ``` - haosdent huang On Nov. 28, 2016, 5:07 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53627/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 5:07 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6556 > https://issues.apache.org/jira/browse/MESOS-6556 > > > Repository: mesos > > > Description > ------- > > Implement a very simple namespaces/uts isolator that can be used to set > the hostname and domainname of a container without the necessity of a > CNI plugin. > > Since we already had a `hostname` field in the ContainerInfo, we can > use that to set the host name once we are in the UTS namespace. Add a > corresponding `domainname` to the ContainerInfo to allow setting the > domain name. > > > Diffs > ----- > > include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 > include/mesos/slave/containerizer.proto > 2621522ae59cf9275f607679b4678ac54508993d > src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb > src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47 > src/slave/containerizer/mesos/containerizer.cpp > 9b33495d9babc3ee489a8712fe1977746c41043f > src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.hpp > 155e3c5a27b8c710971ee4b508600d3b5589a2e0 > src/slave/containerizer/mesos/launch.cpp > 320e42748adbabf09f77cb4f5951e2a7ea58fe64 > src/tests/containerizer/isolator_tests.cpp > 9766aaf144722b18d88f694ff37ffd53974cb60d > > Diff: https://reviews.apache.org/r/53627/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > James Peach > >
