> On Nov. 29, 2016, 7:02 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/launch.cpp, line 431 > > <https://reviews.apache.org/r/53627/diff/6/?file=1571137#file1571137line431> > > > > Wouldn't we need to set up something in `/etc/hosts`. I believe DNS > > lookups on the hostname would fail if the `/etc/nsswitch.conf` does not > > have `myhostname` set in the `hosts` field. > > James Peach wrote: > There's no requirement for the hostname to be resolvable or map to any IP > address on the system. However, since the hostname is set by the framework, > one option could be to set it to the name of the service VIP. > > Avinash sridharan wrote: > I think libprocess might find this problematic. Currently libprocess > tries to resolve the `hostname` to an IP if no IP is explicitly provided: > > https://github.com/apache/mesos/blob/1fc0551db54cd4492c3772d68212b9d7c6571728/3rdparty/libprocess/src/process.cpp#L1145 > > Setting the name to the service IP might not work since the service IP > (as I understand) could be a virtual IP and might not exist on the host, and > for libprocess this needs to be a "bindable" IP. I am assuming you were > implying that by setting the name to the service VIP the hostname can be > resolved through DNS?
I'd call that libprocess code optimistic :) - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/#review157300 ----------------------------------------------------------- On Nov. 28, 2016, 5:07 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53627/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 5:07 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6556 > https://issues.apache.org/jira/browse/MESOS-6556 > > > Repository: mesos > > > Description > ------- > > Implement a very simple namespaces/uts isolator that can be used to set > the hostname and domainname of a container without the necessity of a > CNI plugin. > > Since we already had a `hostname` field in the ContainerInfo, we can > use that to set the host name once we are in the UTS namespace. Add a > corresponding `domainname` to the ContainerInfo to allow setting the > domain name. > > > Diffs > ----- > > include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 > include/mesos/slave/containerizer.proto > 2621522ae59cf9275f607679b4678ac54508993d > src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb > src/cli/execute.cpp ddf7ecac21f2680c3027fafeb4194a2dd4a66d47 > src/slave/containerizer/mesos/containerizer.cpp > 9b33495d9babc3ee489a8712fe1977746c41043f > src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.hpp > 155e3c5a27b8c710971ee4b508600d3b5589a2e0 > src/slave/containerizer/mesos/launch.cpp > 320e42748adbabf09f77cb4f5951e2a7ea58fe64 > src/tests/containerizer/isolator_tests.cpp > 9766aaf144722b18d88f694ff37ffd53974cb60d > > Diff: https://reviews.apache.org/r/53627/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > James Peach > >
