----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/#review158027 -----------------------------------------------------------
Aha, just saw this. I still suggest that we inline those methods so the test looks more self contained. - Jie Yu On Dec. 5, 2016, 5:29 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53689/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 5:29 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-6557 > https://issues.apache.org/jira/browse/MESOS-6557 > > > Repository: mesos > > > Description > ------- > > Use a common fixture for the PID namespace test. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > da4627846730abd3a817c3d538ff5676c3c1ef45 > > Diff: https://reviews.apache.org/r/53689/diff/ > > > Testing > ------- > > Make check in Fedora 24. > > > Thanks, > > James Peach > >