----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158089 -----------------------------------------------------------
src/tests/master_tests.cpp (line 4917) <https://reviews.apache.org/r/54361/#comment228792> How about s/AddMultiRoleFramework/AddFrameworkWithMultiRoles src/tests/master_tests.cpp (line 4947) <https://reviews.apache.org/r/54361/#comment228794> s/response.get().body/response->body src/tests/master_tests.cpp (line 4949) <https://reviews.apache.org/r/54361/#comment228793> ditto src/tests/master_tests.cpp (line 4957) <https://reviews.apache.org/r/54361/#comment228800> When this role was added? src/tests/master_tests.cpp (line 4967) <https://reviews.apache.org/r/54361/#comment228796> ditto src/tests/master_tests.cpp (line 4978) <https://reviews.apache.org/r/54361/#comment228797> ditto src/tests/master_tests.cpp (lines 4991 - 4992) <https://reviews.apache.org/r/54361/#comment228798> new line here src/tests/master_tests.cpp (line 4992) <https://reviews.apache.org/r/54361/#comment228795> EXPECT_SOME_EQ(expected.get(), parse); - Guangya Liu On 十二月 5, 2016, 6:13 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54361/ > ----------------------------------------------------------- > > (Updated 十二月 5, 2016, 6:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure roles from multi-role framework are added. > > > Diffs > ----- > > src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 > > Diff: https://reviews.apache.org/r/54361/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER="MasterTest.AcceptMultiRoleFramework" > make check > > > Thanks, > > Jay Guo > >
