> On Dec. 6, 2016, 12:52 a.m., Guangya Liu wrote: > > src/tests/master_tests.cpp, line 4957 > > <https://reviews.apache.org/r/54361/diff/2/?file=1576136#file1576136line4957> > > > > When this role was added?
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L3254-L3268 Default role `"*"` is always inserted in the response. > On Dec. 6, 2016, 12:52 a.m., Guangya Liu wrote: > > src/tests/master_tests.cpp, line 4992 > > <https://reviews.apache.org/r/54361/diff/2/?file=1576136#file1576136line4992> > > > > EXPECT_SOME_EQ(expected.get(), parse); We already did `ASSERT_SOME(parse)` when we get response, so I think `EXPECT_EQ` is sufficient here. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158089 ----------------------------------------------------------- On Dec. 5, 2016, 6:13 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54361/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 6:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure roles from multi-role framework are added. > > > Diffs > ----- > > src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 > > Diff: https://reviews.apache.org/r/54361/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER="MasterTest.AcceptMultiRoleFramework" > make check > > > Thanks, > > Jay Guo > >
