----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53552/#review158441 -----------------------------------------------------------
Ship it! LGTM. These appear to be unnecessary on all the systems/compilers I've tried (GCC, Clang; OSX, Windows, Ubuntu 14, Centos 7). - Joseph Wu On Dec. 2, 2016, 4:06 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53552/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 4:06 p.m.) > > > Review request for mesos, Daniel Pravat and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The use of `typename` in C++ is used to disambiguate between static > members and dependent names that use the same symbol. For example, if > you have some `T::iterator` and `T` happens to have a static member > called iterator, it is necessary to add `typename T::iterator` to > indicate that you want an iterator of `T` rather than to refer to teh > static member `T::iterator`. > > In some cases we employ `typename` to make our intention clearer, even > though it is not strictly speaking necessary. While normally a good > habit, in the specific cases we change in this review, it causes MSVC to > explode. > > This commit will remove these uses. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 3b759494071c4cae4b8b7dbcb0028df4146fc30e > > Diff: https://reviews.apache.org/r/53552/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
