----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53710/#review158447 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 198) <https://reviews.apache.org/r/53710/#comment229222> Nit: The indentation here should be 2 spaces, not 4. Ditto below. I can tweak this before committing. - Joseph Wu On Nov. 13, 2016, 9:44 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53710/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 9:44 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Removed warnings from `dirent.hpp`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/dirent.hpp > fe3321060646089d3f0d8c5a3ebc0b207161740f > > Diff: https://reviews.apache.org/r/53710/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >