> On Dec. 9, 2016, 7:45 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 400-402 > > <https://reviews.apache.org/r/53802/diff/7/?file=1581066#file1581066line400> > > > > Any reason this is in the locked section? The implication of it being > > locked it that there are accesses off of the event loop thread which does > > not appear to be the case?
Ah, good point! I was thrown off by the access which occurs in `recv()`, but it's in a block that is executed on the event loop so it's safe. Thx! > On Dec. 9, 2016, 7:45 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, line 349 > > <https://reviews.apache.org/r/53802/diff/7/?file=1581066#file1581066line349> > > > > Not yours, but what is a "valid" error? I decided to simply remove this comment, since the code is pretty self-explanatory. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/#review158710 ----------------------------------------------------------- On Dec. 9, 2016, 9:19 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53802/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 9:19 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > Previously, it was possible for an SSL socket to either: > 1) Fail to receive an EOF if the EOF event was received when > there was no pending recv() request. > 2) Fail to receive all data sent on the sending side if an > EOF event was received before all sent data was read. > > This patch eliminates these race conditions to ensure reliable > receipt of both sent data and EOFs. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_ssl_socket.hpp > 57eaf4f607d0628db466cc1a139772eeeaa51136 > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > dddd0e292a8b0d470f4e199db08f09a0c863d73c > > Diff: https://reviews.apache.org/r/53802/diff/ > > > Testing > ------- > > Testing details are found at the end of this chain. > > > Thanks, > > Greg Mann > >
