----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/#review158778 -----------------------------------------------------------
3rdparty/libprocess/src/http.cpp (lines 1323 - 1326) <https://reviews.apache.org/r/54627/#comment229579> Instead of hard coding it, we can add a second parameter 'kind' and let the caller decide what to use. - Jie Yu On Dec. 10, 2016, 6:29 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54627/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2016, 6:29 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-6775 > https://issues.apache.org/jira/browse/MESOS-6775 > > > Repository: mesos > > > Description > ------- > > The 'http::connect(address)' variant of 'http::connect()' doesn't > currently support SSL. However, when SSL is enabled, the default for > all 'Socket::create()' calls is to use the 'DEFAULT_KIND()' of socket > which is set to SSL. This causes problems with 'connect()' because it > will create a socket of 'kind' SSL without a way to override it. > > This commit forces all calls to this variant of 'connect()' to > explicitly set 'kind' to 'POLL' in the 'Socket::create()' call. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp c0eaeff28ea5005d4dfae32118cb8e0f5e650a67 > > Diff: https://reviews.apache.org/r/54627/diff/ > > > Testing > ------- > > ../configure --enable-ssl --enable-libevent > GTEST_FILTER="" make -j check > src/mesos-tests > > > Thanks, > > Kevin Klues > >
