----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/#review158822 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (lines 1323 - 1325) <https://reviews.apache.org/r/54627/#comment229640> I would try to avoid this. That means if we configure mesos with `--enable-ssl`, when Mesos connect to a remote address, it'll use ssl socket. I would simply remove this 'connect' overload to force caller to think about which HTTP scheme to use. - Jie Yu On Dec. 11, 2016, 4:35 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54627/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 4:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-6775 > https://issues.apache.org/jira/browse/MESOS-6775 > > > Repository: mesos > > > Description > ------- > > Updated address of 'http::connect()' with http scheme for SSL support. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 22fa31de0c632758f5e16b36df55bf397402af22 > 3rdparty/libprocess/src/http.cpp c0eaeff28ea5005d4dfae32118cb8e0f5e650a67 > > Diff: https://reviews.apache.org/r/54627/diff/ > > > Testing > ------- > > ../configure --enable-ssl --enable-libevent > GTEST_FILTER="" make -j check > src/mesos-tests > sudo src/mesos-tests > > ../configure > GTEST_FILTER="" make -j check > src/mesos-tests > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
