----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54655/#review158975 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp (lines 558 - 559) <https://reviews.apache.org/r/54655/#comment229876> How did we get from required/optional to framework/executor/command_info? The connection isn't obvious without reading through the code and the callers' code. src/authorizer/local/authorizer.cpp (lines 582 - 583) <https://reviews.apache.org/r/54655/#comment229878> What's optional here? Should there be a `object.has_command_info()` in there somewhere? - Adam B On Dec. 12, 2016, 1:51 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54655/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 1:51 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Renames `LocalNestedContainerObjectApprover` to > `CombinedACLObjectApprover` in order to allow uses beyond nested > containers. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 3b983d0c0dea3ad761e7c684a9f943809dc541e9 > > Diff: https://reviews.apache.org/r/54655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
