> On Dec. 13, 2016, 2:24 a.m., Benjamin Bannier wrote: > >
Yeah these are often the source of confusion. We should clarify them in the style guide. (Just sent an email: https://lists.apache.org/thread.html/b99a26d43410eaa3cf45c634e6f45abee012b82b14dd2d2685ecb8e8@%3Cdev.mesos.apache.org%3E) > On Dec. 13, 2016, 2:24 a.m., Benjamin Bannier wrote: > > src/tests/containerizer/rootfs.cpp, line 29 > > <https://reviews.apache.org/r/53790/diff/7/?file=1571589#file1571589line29> > > > > Please include this one before any other headers. For now let's stick to the common pratice of treating it the same way as the other project files. I can take care of this. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/#review158980 ----------------------------------------------------------- On Dec. 13, 2016, 10:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53790/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 10:36 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Move containerizer Rootfs support to a cpp file. > > No functional changes. This is just moving the existing code. > > > Diffs > ----- > > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c > src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f > src/tests/containerizer/rootfs.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53790/diff/ > > > Testing > ------- > > sudo make check (Fedora 24). > > > Thanks, > > James Peach > >
