----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53790/#review159105 -----------------------------------------------------------
Ship it! Now that the implementation is moved to cpp, we typically prefer using declaration + unqualified types in the code. Ideally it should be done in this patch but I see that you are already doing it (partiall) in /r/53791/ so it's fine to fix it there too. - Jiang Yan Xu On Dec. 13, 2016, 10:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53790/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 10:36 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Move containerizer Rootfs support to a cpp file. > > No functional changes. This is just moving the existing code. > > > Diffs > ----- > > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c > src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f > src/tests/containerizer/rootfs.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53790/diff/ > > > Testing > ------- > > sudo make check (Fedora 24). > > > Thanks, > > James Peach > >
