----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review159352 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 167) <https://reviews.apache.org/r/54212/#comment230316> Do you need to create the directory first? backendDir/scratch/links might not exist? Don't understand why the test passes. Have you tested on a system with overlayfs enabled? src/tests/containerizer/provisioner_backend_tests.cpp (line 96) <https://reviews.apache.org/r/54212/#comment230319> instead of using os::getcwd(). let's use sandbox.get() consistently in this file. src/tests/containerizer/provisioner_backend_tests.cpp (lines 152 - 153) <https://reviews.apache.org/r/54212/#comment230321> Why change those, but not others in this file? If you don't do the change, anything breaks? - Jie Yu On Dec. 15, 2016, 5:52 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54212/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 5:52 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao > Li. > > > Bugs: MESOS-6653 > https://issues.apache.org/jira/browse/MESOS-6653 > > > Repository: mesos > > > Description > ------- > > Since the fix of MESOS-6000, symlinks are used in overlayfs > backend to shorten the arguments when mounting the rootfs. > E.g., '.../backends/overlay/links' is the symlink created > for a provisioned image. It becomes problematic if a > container image is specified while some image volumes are > specified for the same container. An unique symlink is > needed for each image to be provisioned. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp > b71a31323aef376c9a28e1d52322a1802fb212ad > src/tests/containerizer/provisioner_backend_tests.cpp > 727bf645dd9337a94f098ab0a816b7e0e0651083 > > Diff: https://reviews.apache.org/r/54212/diff/ > > > Testing > ------- > > make check > > Verified that the unit test `ROOT_ImageInVolumeWithRootFilesystem` passed. > > > Thanks, > > Gilbert Song > >
