----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review162576 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (lines 158 - 159) <https://reviews.apache.org/r/54212/#comment233924> What I was suggesting was to use: ``` backendDir/scratch/<rootfsId>/links ``` as tempLink. Also, can you update the comments in overlay.hpp? - Jie Yu On Jan. 19, 2017, 12:08 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54212/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 12:08 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian > Zhang, and Zhitao Li. > > > Bugs: MESOS-6653 > https://issues.apache.org/jira/browse/MESOS-6653 > > > Repository: mesos > > > Description > ------- > > Since the fix of MESOS-6000, symlinks are used in overlayfs > backend to shorten the arguments when mounting the rootfs. > E.g., '.../backends/overlay/links' is the symlink created > for a provisioned image. It becomes problematic if a > container image is specified while some image volumes are > specified for the same container. An unique symlink is > needed for each image to be provisioned. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp > a6e6c8b84adadc24b915b45533d1789f8de758dd > > Diff: https://reviews.apache.org/r/54212/diff/ > > > Testing > ------- > > make check > > Verified that the unit test `ROOT_ImageInVolumeWithRootFilesystem` passed. > > > Thanks, > > Gilbert Song > >
