----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54796/#review159456 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On Dec. 15, 2016, 10:02 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54796/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2016, 10:02 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > The way process' `Loop` abstraction is used ensures that `Loop` > instances life long enough that outstanding continuations are not > working with destructed data. This is done by capturing > lifetime-extending handles by value into any continuation. > > Nevertheless, even though continuations always have access to save > handles (captured via `self`), the code was still accessing `Loop` > members via explicitly captured `this` pointers. This appears > needlessly alarming since safe access would always be possible via > `self`. > > This change replaces access to `Loop` data via potentially (but > currently not actually) unsafe `this` pointers with access via the > safe `self`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/loop.hpp > ac54b631be5016ea7bc42b724a5883360718f0f2 > > Diff: https://reviews.apache.org/r/54796/diff/ > > > Testing > ------- > > * `make check` (Mac OS 10.12, clang-trunk, w/ optimizations, SSL) > * `make check` (Fedora 25, clang-3.8, w/optimizations, SSL) > > > Thanks, > > Benjamin Bannier > >
