> On Nov. 23, 2016, 9:27 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake, lines 97-98 > > <https://reviews.apache.org/r/52190/diff/2/?file=1569355#file1569355line97> > > > > Can you add some comments above these? > > > > I presume that the first definition silences some MSVC or CRT warnings. > > But what does the second definition do?
These defines are used to suppress the warnings from Winsock APIs used in int_fd. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/#review156785 ----------------------------------------------------------- On Nov. 23, 2016, 5:12 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52190/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 5:12 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Removed deprecated compiler warnings. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 11a8507eb773391073a7b945e2aac503262f86b7 > > Diff: https://reviews.apache.org/r/52190/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
