----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53718/#review159747 -----------------------------------------------------------
Fix it, then Ship it! I can fix this up before committing. src/slave/containerizer/docker.cpp (line 368) <https://reviews.apache.org/r/53718/#comment230778> There are two other occurrences of the string that should be substituted. src/slave/containerizer/docker.cpp (line 1377) <https://reviews.apache.org/r/53718/#comment230779> And here. Technically, argv[0] doesn't *need* to have the `.exe`. But we might as well be consistent. - Joseph Wu On Nov. 13, 2016, 9:42 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53718/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 9:42 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Defined and used Windows string `docker-mesos-executor.exe`. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/53718/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
