----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review160402 -----------------------------------------------------------
Fix it, then Ship it! Looks good minus a few minor issues. I would fix them while committing. src/tests/api_tests.cpp (line 1494) <https://reviews.apache.org/r/52639/#comment231531> s/Ensure/Ensure that to be consistent with the comment on L1523 src/tests/master_tests.cpp (lines 4145 - 4146) <https://reviews.apache.org/r/52639/#comment231532> Let's make it consistent with a similar comment in the earlier test. Also, a newline after the comment since it applies to both the following code blocks. ```cpp // After the agent has successfully re-registered with the master, the `recovered_slaves` field would be empty in both `/state` and `/slave` endpoints. ``` src/tests/master_tests.cpp (line 4158) <https://reviews.apache.org/r/52639/#comment231534> s/parse1/parse src/tests/master_tests.cpp (line 4180) <https://reviews.apache.org/r/52639/#comment231535> s/parse1/parse - Anand Mazumdar On Dec. 30, 2016, 11:05 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52639/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2016, 11:05 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar. > > > Bugs: MESOS-6177 > https://issues.apache.org/jira/browse/MESOS-6177 > > > Repository: mesos > > > Description > ------- > > Added test for `recovered` AgentID and `AGENT_ADDED` after reregister. > > > Diffs > ----- > > src/tests/api_tests.cpp e3138699aa883919329aee47a6d93b5a9a9794b2 > src/tests/master_tests.cpp 2d0cd8244ded44e76f0eee3d87327ff526db5208 > > Diff: https://reviews.apache.org/r/52639/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
