----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review160813 -----------------------------------------------------------
You may also want a test case in https://github.com/apache/mesos/blob/master/src/tests/master_validation_tests.cpp src/master/master.cpp (lines 2400 - 2418) <https://reviews.apache.org/r/55271/#comment232041> I think that you may also want to apply this to https://github.com/apache/mesos/blob/master/src/master/master.cpp#L2535 ``` void Master::subscribe( const UPID& from, const scheduler::Call::Subscribe& subscribe) ``` - Guangya Liu On 一月 6, 2017, 7:07 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated 一月 6, 2017, 7:07 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.cpp 11c34a048586d30c6ac67be8638ed8fa81cc3f1f > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
