> On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote: > > src/master/master.cpp, line 2490 > > <https://reviews.apache.org/r/55271/diff/5/?file=1603888#file1603888line2490> > > > > I think that you may want to > > ``` > > #include <stout/hashset.hpp> > > ```
This is already added as part of this patch. > On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote: > > src/master/master.cpp, lines 2473-2506 > > <https://reviews.apache.org/r/55271/diff/5/?file=1603888#file1603888line2473> > > > > Can you move this right after 2448 to group the logic related with role? Done, also for `Master::subscribe(const UPID&, const scheduler::Call::Subscribe&)`. > On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 2616 > > <https://reviews.apache.org/r/55271/diff/5/?file=1603889#file1603889line2616> > > > > How about s/RejectRolesChange/RejectRolesChangeWithMutiRole When I named the test `RejectRolesChange` instead of `RejectRoleChange` I was hoping it would already be clear that this test would deal with a multi-role scenario. Was that too subtle? I would like to avoid excessive redundancy in the test name. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161648 ----------------------------------------------------------- On Jan. 12, 2017, 4:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 4:32 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
