----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160821 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/linux.hpp (line 58) <https://reviews.apache.org/r/54996/#comment232048> s/DefaultSize/DEFAULT_SIZE/ 3rdparty/stout/include/stout/os/linux.hpp (line 60) <https://reviews.apache.org/r/54996/#comment232047> It's weird that we allow copy constructor but disallow assignment operator. Let's just remove this. 3rdparty/stout/include/stout/os/linux.hpp (line 66) <https://reviews.apache.org/r/54996/#comment232046> I typically prefer one extra blank line before this comment 3rdparty/stout/include/stout/os/linux.hpp (lines 70 - 71) <https://reviews.apache.org/r/54996/#comment232044> I would prefer align the code like the following: ``` if (::posix_memalign( reinterpret_cast<void**>(&stack.address), os::pagesize(), stack.size) != 0) { return ErrnoError("Memory allocation failed"); } ``` 3rdparty/stout/include/stout/os/linux.hpp (line 71) <https://reviews.apache.org/r/54996/#comment232043> please use os::pagesize() here. 3rdparty/stout/include/stout/os/linux.hpp (line 72) <https://reviews.apache.org/r/54996/#comment232045> Please use errno error so that errno are in the error string. `return ErrnoError("Memory allocation failed");` - Jie Yu On Jan. 4, 2017, 9:55 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54996/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 9:55 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6835 > https://issues.apache.org/jira/browse/MESOS-6835 > > > Repository: mesos > > > Description > ------- > > Currently in the Linux launcher when the stack is allocated and prepared for > a call to clone() it is not properly aligned. This is not an issue for x86 or > x64 but for ARM64/AArch64 it is because of the requirement of having the > stack aligned to a 16 byte boundary. While x86 and x64 also expect the stack > to have a 16 byte aligned stack, it is not enforced. An explanation of the > stack and requirements for ARM64 can be found here > http://infocenter.arm.com/help/topic/com.arm.doc.ihi0055b/IHI0055B_aapcs64.pdf > (specifically section 5.2.2.1 that says SP mod 16 = 0. The stack must be > quad-word aligned.) > > Additionally, the way that the stack is currently allocated and passed to > clone() accidentally chops off one entry, making a stack overflow using those > missing 8 bytes a possibility. Fixing this while aligning the memory will fix > both the issue of the stack overflow issue as well as the SIGBUS crash. We > should also net better performance from having the stack aligned. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/linux.hpp 530f1a55b > src/linux/ns.hpp 77789717e > > Diff: https://reviews.apache.org/r/54996/diff/ > > > Testing > ------- > > Built Mesos from source and am currently running it in a test cluster. > Launched both Docker and Mesos tasks via Marathon without any resulting crash > (initial crash only happened with Mesos containerizer + linux_launcher, not > with the posix_launcher). > > > Thanks, > > Aaron Wood > >
