> On Dec. 20, 2016, 1:54 p.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 2453
> > <https://reviews.apache.org/r/54613/diff/2/?file=1589128#file1589128line2453>
> >
> >     Not yours, but since you touch this it would be great if you could make 
> > these independent commands (i.e., remove the ` &&` here).
> >     
> >     I added more cleanups here, https://reviews.apache.org/r/54896/.

Done.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54613/#review159714
-----------------------------------------------------------


On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54613/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael 
> Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6772
>     https://issues.apache.org/jira/browse/MESOS-6772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Install a symlink rather than building mesos-slave twice.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
> 
> Diff: https://reviews.apache.org/r/54613/diff/
> 
> 
> Testing
> -------
> 
> Make install:
> ```
> [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/
> total 10448
> -rwxr-xr-x 1 root root 5116104 Dec  9 15:27 mesos-agent*
> -rwxr-xr-x 1 root root 5539096 Dec  9 15:27 mesos-master*
> lrwxrwxrwx 1 root root      11 Dec  9 15:27 mesos-slave -> mesos-agent*
> ```
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to