> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote: > > What is the reason for this change? It seems much more intuitive for me to > > have a simple build directive that we simply remove once of the rename is > > complete, compared to a custom install-hook that creates a symlink. > > James Peach wrote: > The rationale is that we don't need to spend time and space building annd > installing an extra binary.
OK. Can you at least retain the comment for: ``` # TODO(tomxing): Remove this binary once the # slave->agent rename is complete(MESOS-3782). ``` so taht we don't forget to remove the install-hook once the full rename is done. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review160958 ----------------------------------------------------------- On Jan. 9, 2017, 8:02 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54613/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 8:02 p.m.) > > > Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael > Park, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6772 > https://issues.apache.org/jira/browse/MESOS-6772 > > > Repository: mesos > > > Description > ------- > > Install a symlink rather than building mesos-slave twice. > > > Diffs > ----- > > src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 > > Diff: https://reviews.apache.org/r/54613/diff/ > > > Testing > ------- > > Make install: > ``` > [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/ > total 10448 > -rwxr-xr-x 1 root root 5116104 Dec 9 15:27 mesos-agent* > -rwxr-xr-x 1 root root 5539096 Dec 9 15:27 mesos-master* > lrwxrwxrwx 1 root root 11 Dec 9 15:27 mesos-slave -> mesos-agent* > ``` > > > Thanks, > > James Peach > >
