----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55238/#review161200 -----------------------------------------------------------
I feel if we keep `os::system()` in the codebase at all, this is one of the few places it could actually be used... we could eliminate it so we can say there's no references to `os::systems()` left today but it's a bit harsh to nit-picking on future use like this in order to keep a "clean state"? - Jiang Yan Xu On Jan. 5, 2017, 5:12 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55238/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 5:12 p.m.) > > > Review request for mesos, Avinash sridharan and Jiang Yan Xu. > > > Bugs: MESOS-6862 > https://issues.apache.org/jira/browse/MESOS-6862 > > > Repository: mesos > > > Description > ------- > > Use os::spawn in the CNI isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > ea91c71fdfac48a2fc1d31a0ee088a73244be367 > > Diff: https://reviews.apache.org/r/55238/diff/ > > > Testing > ------- > > `sudo make check` (Fedora 25) > > > Thanks, > > James Peach > >
