----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review161367 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/master_validation_tests.cpp (lines 2593 - 2596) <https://reviews.apache.org/r/55381/#comment232608> How about following to avoid a new line between for `add_capabilities`? ``` frameworkInfo.add_roles(frameworkInfo.role()); frameworkInfo.clear_role(); frameworkInfo.add_capabilities()->set_type( FrameworkInfo::Capability::MULTI_ROLE); ``` src/tests/master_validation_tests.cpp (lines 2604 - 2605) <https://reviews.apache.org/r/55381/#comment232606> new line here - Guangya Liu On 一月 11, 2017, 10:37 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55381/ > ----------------------------------------------------------- > > (Updated 一月 11, 2017, 10:37 a.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6900 > https://issues.apache.org/jira/browse/MESOS-6900 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55381/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Benjamin Bannier > >
