> On Jan. 16, 2017, 5:37 a.m., Jay Guo wrote: > > src/tests/master_validation_tests.cpp, line 2559 > > <https://reviews.apache.org/r/55381/diff/3/?file=1603887#file1603887line2559> > > > > I think this test is not valid since we currently don't have logic to > > check framework upgrade yet. > > > > This test passes because `role` update is ignored with a warning > > generated here: > > https://github.com/apache/mesos/blob/master/src/master/master.hpp#L2488-L2491 > > > > `roles` field is actually not checked against old `role`. > > Jay Guo wrote: > Just saw next patch in the review chain. Could you reverse the order > since this test should actually goes after the framework upgrade patch.
I explicitly moved it to the start of the chain. That way we can make sure the next patch does not introduce regressions. What do you think. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review161676 ----------------------------------------------------------- On Jan. 12, 2017, 4:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55381/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 4:32 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6900 > https://issues.apache.org/jira/browse/MESOS-6900 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55381/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Benjamin Bannier > >
