----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55488/#review161503 -----------------------------------------------------------
Fix it, then Ship it! support/mesos-tidy/Dockerfile <https://reviews.apache.org/r/55488/#comment232799> Agree that this one is better in its own section. support/mesos-tidy/Dockerfile (lines 68 - 71) <https://reviews.apache.org/r/55488/#comment232800> These packages are from the Mesos getting started guide, and I am not sure we would like to deviate here. It does save about 400MB in this layer (probably since we do not install the java packages), but we'll likely be perpetually out of sync as the Mesos cmake setup approaches the autotool setup's capabilities. support/mesos-tidy/Dockerfile (line 76) <https://reviews.apache.org/r/55488/#comment232801> Please wrap this RUN apt-get install -qy \ jq \ parallel Not yours, but it probably makes sense to terminate the command with an `apt-get clean` just for consistency (this safes almost no space for that layer). - Benjamin Bannier On Jan. 13, 2017, 10:54 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55488/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 10:54 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464 > > Diff: https://reviews.apache.org/r/55488/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
