> On Jan. 13, 2017, 12:53 p.m., Benjamin Bannier wrote:
> > support/mesos-tidy/Dockerfile, lines 69-77
> > <https://reviews.apache.org/r/55488/diff/1/?file=1604404#file1604404line69>
> >
> >     These packages are from the Mesos getting started guide, and I am not 
> > sure we would like to deviate here. It does save about 400MB in this layer 
> > (probably since we do not install the java packages), but we'll likely be 
> > perpetually out of sync as the Mesos cmake setup approaches the autotool 
> > setup's capabilities.
> 
> Michael Park wrote:
>     - `libev` is bundled.
>     - `libevent` is not, but we download it via `ExternalProject` for CMake.
>     - `libssl` is not supported by CMake, but I imagine we'll be taking the 
> same approach as `libevent`. We can adjust if it changes.
>     - We don't build the Java stuff with CMake and frankly I don't think we 
> care about it... so I dropped `maven` and `openjdk-8-jdk`.
>     
>     Let me know if you still think I should add any of them back.

Makes sense, after all the getting started guide isn't really geared towards 
the cmake build; also, we can always add back stuff later.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/#review161503
-----------------------------------------------------------


On Jan. 13, 2017, 10:54 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55488/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 10:54 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464 
> 
> Diff: https://reviews.apache.org/r/55488/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to