> On Jan. 9, 2017, 5:03 p.m., Gilbert Song wrote: > > src/slave/flags.cpp, line 174 > > <https://reviews.apache.org/r/52379/diff/6/?file=1596001#file1596001line174> > > > > Why not consistent with docker/appc store?
This was a suggestion of Avinash when he reviewed the design doc, the reason that we do not choose /tmp/mesos/store/oci is, /tmp is a tmpfs (or ramfs) an in-memory file system, the OCI images can be quite big (as with docker images) and might end up filling this file system very fast. And another reason is /tmp will be automatically cleared upon agent host reboot which is also what we do not want. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/#review160873 ----------------------------------------------------------- On Jan. 3, 2017, 10:17 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52379/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 10:17 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Added agent flag '--oci_store_dir'. > > > Diffs > ----- > > docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d > docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded > docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b > src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153 > src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 > src/slave/http.cpp b6e2d4f9190358d113b39140d116b8659ddbb49b > > Diff: https://reviews.apache.org/r/52379/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
