----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/#review161861 -----------------------------------------------------------
include/mesos/docker/v2_s2.proto (line 17) <https://reviews.apache.org/r/53849/#comment233140> I would probably use v2_2 instead of v2.s2. I'll also rename this file to v2_2.proto include/mesos/docker/v2_s2.proto (lines 29 - 33) <https://reviews.apache.org/r/53849/#comment233143> I would pull this to the top level and call it `Descriptor` (refer to OCI image spec). include/mesos/docker/v2_s2.proto (lines 37 - 42) <https://reviews.apache.org/r/53849/#comment233144> This is `Descriptor` as well. No need to define again. src/CMakeLists.txt (line 32) <https://reviews.apache.org/r/53849/#comment233141> `DOCKER_V2_2` - Jie Yu On Nov. 28, 2016, 4:53 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53849/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 4:53 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-3505 > https://issues.apache.org/jira/browse/MESOS-3505 > > > Repository: mesos > > > Description > ------- > > Added parsing of V2 schema 2 Docker image manifests. > > > Diffs > ----- > > include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 > include/mesos/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f > include/mesos/docker/v2_s2.proto PRE-CREATION > src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 > src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 > src/docker/spec.cpp 2f2c32e9b7d78debb31dcc1aa91a4d45c1ced192 > src/tests/containerizer/docker_spec_tests.cpp > 82bddd228df3db95a00eb277ff9c380039b70b1e > > Diff: https://reviews.apache.org/r/53849/diff/ > > > Testing > ------- > > Added tests to verify that V2 schema 2 image manifest can be successfully > parsed and errors like missing required fields or empty layers list are > caught. Ran `make check`. > > > Thanks, > > Ilya Pronin > >
