> On Jan. 18, 2017, 3:36 a.m., Jay Guo wrote: > > src/master/master.hpp, lines 2522-2528 > > <https://reviews.apache.org/r/55271/diff/9/?file=1606938#file1606938line2522> > > > > This check is only valid **iff** both `src` and `dest` frameworkInfo > > are single role, isn't it? maybe > > ```cpp > > if (!capabilities.multiRole && > > !protobuf::frameworkHasCapability( > > source, FrameworkInfo::Capability::MULTI_ROLE) && > > source.role() != info.role()) { > > ... > > }
Also updated the comment. I did use `protobuf::frameworkHasCapability` in both cases for uniformity. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review162021 ----------------------------------------------------------- On Jan. 17, 2017, 11:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 11:20 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
