----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161828 -----------------------------------------------------------
Also, should we allow user to downgrade from a multi-role framework to single-role? I feel it would be very complicated and we should explicitly disallow that... src/master/master.hpp (lines 2522 - 2525) <https://reviews.apache.org/r/55271/#comment233129> This warning is not always true in case framework is being upgraded from single-role to multi-role. - Jay Guo On Jan. 16, 2017, 7:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 7:28 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
