----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55727/#review162375 -----------------------------------------------------------
Patch looks great! Reviews applied: [53105, 53330, 55727] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Jan. 19, 2017, 8:09 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55727/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 8:09 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6893 > https://issues.apache.org/jira/browse/MESOS-6893 > > > Repository: mesos > > > Description > ------- > > This patch added the following capabilities: > 1. add the size and fetch timestamp of each docker image layer in metadata; > 2. checkpoint and recover size (timestamp will be added later); > 3. reuse the `DiskUsageCollector` class to track size of each downloaded > store; > 4. for upgrade path, reuse same collector to back fill the size of layers. > > Tests to be added later. Sending out review for earlier feedback. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/message.proto > c93c7a92ec152bd9747a70392adfe6a0e863e839 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp > 954da1681778878c8aff6150002e52ecb648d1bb > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > 395c36b0f6b8f8e037681ec5f2df99e83a7cf155 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > Diff: https://reviews.apache.org/r/55727/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
