----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review162883 -----------------------------------------------------------
This review is partially un-done by https://reviews.apache.org/r/55604/ . Can you separate the source-grouping changes into https://reviews.apache.org/r/55604/ ? And leave the CMake lists rearrangement in this review? - Joseph Wu On Jan. 15, 2017, 12:47 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55030/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 12:47 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Bugs: MESOS-3542 > https://issues.apache.org/jira/browse/MESOS-3542 > > > Repository: mesos > > > Description > ------- > > Currently in IDEs such as XCode and Visual Studio, all mesos source > files are grouped into one huge folder, with no attempt made to reflect > the hierarchy of folders that exist on disk. > > This commit groups libprocess files into relevant source groups so that > they appear in a sensible directory structure in these IDEs. > > In addition to beginning to directly address MESOS-3542, this is also > (indirectly) the first step towards addressing the problem of breaking > libmesos up into smaller binaries (MESOS-3542). > > > Diffs > ----- > > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 873f41d844faa0d442f77411e94314a89be5f046 > 3rdparty/libprocess/src/CMakeLists.txt > 60f0e76dfd237d9a12a366b413802d1a96892b55 > 3rdparty/libprocess/src/tests/CMakeLists.txt > 0b2660cb16f5d8d8dc66e6995061d0b832182351 > > Diff: https://reviews.apache.org/r/55030/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
