----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55825/#review162933 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp (line 1942) <https://reviews.apache.org/r/55825/#comment234328> Labeling `allocated:` seems okay to me, but also seems to be new to this format. It's not clear to me what direction we're going with this, seeing as it's gotten (and getting) more complicated. I think the eventual plan is to move to using JSON for this representation? Just would like your quick thoughts on this. - Michael Park On Jan. 22, 2017, 6:04 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55825/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 6:04 p.m.) > > > Review request for mesos, Jay Guo, Guangya Liu, and Michael Park. > > > Bugs: MESOS-6970 > https://issues.apache.org/jira/browse/MESOS-6970 > > > Repository: mesos > > > Description > ------- > > Ignoring whether there is a disk info, the format is as follows: > name(reservedrole[, principal[, labels]])(allocatedrole):value > > > Diffs > ----- > > src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 > src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 > src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267 > > Diff: https://reviews.apache.org/r/55825/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Benjamin Mahler > >
