----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55825/#review162939 -----------------------------------------------------------
src/tests/resources_tests.cpp (line 822) <https://reviews.apache.org/r/55825/#comment234330> How about not clear this but keep the `allocated` label for all of the test or just add this to the end of this test after line 883? This can convine us that the `allocated` label works for all kind of resources. - Guangya Liu On 一月 23, 2017, 2:04 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55825/ > ----------------------------------------------------------- > > (Updated 一月 23, 2017, 2:04 a.m.) > > > Review request for mesos, Jay Guo, Guangya Liu, and Michael Park. > > > Bugs: MESOS-6970 > https://issues.apache.org/jira/browse/MESOS-6970 > > > Repository: mesos > > > Description > ------- > > Ignoring whether there is a disk info, the format is as follows: > name(reservedrole[, principal[, labels]])(allocatedrole):value > > > Diffs > ----- > > src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 > src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 > src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267 > > Diff: https://reviews.apache.org/r/55825/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Benjamin Mahler > >
