> On Jan. 25, 2017, 5:41 p.m., haosdent huang wrote: > > Do you forgot to update `src/Makefile.am` > > > > ``` > > nobase_dist_pkgdata_DATA += \ > > webui/master/static/js/angular-1.2.3.js \ > > webui/master/static/js/angular-1.2.3.min.js > > \ > > webui/master/static/js/angular-route-1.2.3.js > > \ > > webui/master/static/js/angular-route-1.2.3.min.js \ > > webui/master/static/js/jquery-1.7.1.js \ > > webui/master/static/js/jquery-1.7.1.min.js > > \ > > webui/master/static/js/relative-date.js \ > > webui/master/static/js/ui-bootstrap-tpls-0.9.0.js \ > > webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js > > \ > > webui/master/static/js/underscore-1.4.3.js > > \ > > webui/master/static/js/underscore-1.4.3.min.js \ > > webui/master/static/js/zeroclipboard-1.1.7.js > > \ > > webui/master/static/js/zeroclipboard-1.1.7.min.js \ > > webui/master/static/obj/zeroclipboard-1.1.7.swf > > > > ```
I have fixed this when submit it, thank you for the contribution! - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55791/#review162975 ----------------------------------------------------------- On Jan. 22, 2017, 6:11 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55791/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 6:11 p.m.) > > > Review request for mesos and haosdent huang. > > > Bugs: MESOS-6969 > https://issues.apache.org/jira/browse/MESOS-6969 > > > Repository: mesos > > > Description > ------- > > - Use pure js clipboard.js and remove > flash dependency. > - Vendored zeroclipboard has security issues > https://www.cvedetails.com/cve/CVE-2014-1869/ > > > Diffs > ----- > > src/webui/master/static/css/mesos.css > c817aaee0fd2d2579ff2e4a152d47e83ce80d68c > src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42 > src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 > src/webui/master/static/js/clipboard-1.5.16.js PRE-CREATION > src/webui/master/static/js/clipboard-1.5.16.min.js PRE-CREATION > src/webui/master/static/js/zeroclipboard-1.1.7.js > d45551d6c9f75c275032219768549f76865b9cd3 > src/webui/master/static/js/zeroclipboard-1.1.7.min.js > 32535fddf1baab255fcbf5d3d776a0a9ac1447e8 > src/webui/master/static/obj/zeroclipboard-1.1.7.swf > 880e64ee7614e224660c6616b4bbb1ee5fab8ec9 > > Diff: https://reviews.apache.org/r/55791/diff/ > > > Testing > ------- > > make check + verification of clipboard functionality > > > Thanks, > > Jacob Janco > >
